22 Nov
2021
22 Nov
'21
10:27 a.m.
Attention is currently required from: Paul Menzel, Julius Werner, Kyösti Mälkki, Rob Barnes, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59322 )
Change subject: console/printk: Disable threading before grabbing the spin lock ......................................................................
Patch Set 9:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59322/comment/868595f6_71181cd5 PS8, Line 13: commit a98d302fe9dc ("x86/smp/spinlock: Disable thread coop when taking spinlock")
IMO you should do a clean revert first, and not have printk() as a special case with spinlock, but u […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/59322
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55d0cd2bcd82721098ca24ae2368bb6a16a07df4
Gerrit-Change-Number: 59322
Gerrit-PatchSet: 9
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Attention: Rob Barnes robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Mon, 22 Nov 2021 18:27:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-MessageType: comment