[coreboot-gerrit] [S] Change in coreboot[master]: mb/google/herobrine: Implement mainboard_needs_pcie_init

[Julius Werner (Code Review)]

Attention is currently required from: Shelley Chen.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69689 )

Change subject: mb/google/herobrine: Implement mainboard_needs_pcie_init
......................................................................

Patch Set 2:

(1 comment)

File src/mainboard/google/herobrine/mainboard.c:

https://review.coreboot.org/c/coreboot/+/69689/comment/b42a1d03_a4e64804 
PS2, Line 104: 	if ((sku & BIT(0)) == 2)
Uhh... pretty sure this doesn't work...?

I don't know how exactly the EC generates the SKU ID, but if it's a normal (not "binary-first") base 3 number (e.g. (pin0 * 3^0 + pin1 * 3^1 + ...)) and you want to check if pin0 was Z, then I think `if (sku % 3 == 2)` is what you want here.