Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39470 )
Change subject: soc/intel/tigerlake: Publish single GPIO ACPI device for Jasper Lake
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39470/3/src/soc/intel/tigerlake/acp...
File src/soc/intel/tigerlake/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/39470/3/src/soc/intel/tigerlake/acp...
PS3, Line 121: Method (GADD, 1, NotSerialized)
This ACPI method looks identical between the two. Can it be retained here and just the GPIO devices moved to the concerned ASL. Is there a downside?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39470
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifcc92adaee550182ab405541ea85019f31bb8658
Gerrit-Change-Number: 39470
Gerrit-PatchSet: 3
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 12 Mar 2020 16:43:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment