Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33116 )
Change subject: Kconfig: Make stage cache kconfig selection proper ......................................................................
Patch Set 17:
(10 comments)
https://review.coreboot.org/c/coreboot/+/33116/17/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/33116/17/src/Kconfig@244 PS17, Line 244: default !NO_RELOCATABLE_STAGES
Chrome EC: clear events_b mask to 0x0000000021004000 […]
Done
https://review.coreboot.org/c/coreboot/+/33116/17/src/Kconfig@248 PS17, Line 248: ramstage to be built as a : relocatable module
Is it right to mention ramstage here since you seem to be making it more of a generic relocatable st […]
Done
https://review.coreboot.org/c/coreboot/+/33116/17/src/Kconfig@258 PS17, Line 258: .
It would be good to mention that the platform is responsible for providing storage for this external […]
Done
https://review.coreboot.org/c/coreboot/+/33116/17/src/Kconfig@262 PS17, Line 262: select RELOCATABLE_MODULES
RELOCATABLE_MODULES can be set to true based on !NO_RELOCATABLE_STAGES? i.e. […]
Done
https://review.coreboot.org/c/coreboot/+/33116/17/src/Kconfig@264 PS17, Line 264: enable
enables
Done
https://review.coreboot.org/c/coreboot/+/33116/17/src/Kconfig@266 PS17, Line 266: chiset
chipset
Done
https://review.coreboot.org/c/coreboot/+/33116/17/src/Kconfig@272 PS17, Line 272: enable
enables
Done
https://review.coreboot.org/c/coreboot/+/33116/17/src/Kconfig@279 PS17, Line 279: NO_RELOCATABLE_STAGES ||
This condition does not look completely right to me. […]
Done
https://review.coreboot.org/c/coreboot/+/33116/17/src/arch/x86/Makefile.inc File src/arch/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/33116/17/src/arch/x86/Makefile.inc@... PS17, Line 378: CONFIG_STAGE_CACHE
That might keep things clear.
Done
https://review.coreboot.org/c/coreboot/+/33116/17/src/include/stage_cache.h File src/include/stage_cache.h:
https://review.coreboot.org/c/coreboot/+/33116/17/src/include/stage_cache.h@... PS17, Line 40: CONFIG_NO_STAGE_CACHE
This should be updated as well.
Done