Attention is currently required from: Alex James.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60233 )
Change subject: util/cbfstool: Avoid duplicate ntohll/htonll definitions
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
bsd/sysincludes.h in commonlib already defines byteswapping functions (from endian(3)). […]
Yes, please just do that, this file is obsolete (at least for those functions).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60233
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54195865ab4042fcf83609fcf67ef8f33994d68e
Gerrit-Change-Number: 60233
Gerrit-PatchSet: 1
Gerrit-Owner: Alex James
theracermaster@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Alex James
theracermaster@gmail.com
Gerrit-Comment-Date: Mon, 20 Dec 2021 23:52:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alex James
theracermaster@gmail.com
Gerrit-MessageType: comment