15 Jan
2019
15 Jan
'19
3:05 p.m.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30848 )
Change subject: mb/emulation/qemu-i440fx: add e820 interface ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/30848/1/src/mainboard/emulation/qemu-i440fx/... File src/mainboard/emulation/qemu-i440fx/fw_cfg.h:
https://review.coreboot.org/#/c/30848/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 22: * Do not call any other fw_cfg_ function between fw_cfg_e820_select and
That's a bad API design. […]
There is a new function to get top of memory. All read and writes are now done in fw_cfg.c internal.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30848
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I547bc7fef09999baa28149a6325cbca91e31e99b
Gerrit-Change-Number: 30848
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Tue, 15 Jan 2019 14:05:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org
Gerrit-MessageType: comment