Paul Menzel (paulepanter@users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9306
-gerrit
commit e8e4c86c6ec7ebdfe00313070a88e62b188398b1 Author: Paul Menzel paulepanter@users.sourceforge.net Date: Sun Apr 5 18:30:05 2015 +0200
arch/arm64/boot.c: Only return if condition is met
Fix up commit b3847e64 (program loading: add prog_run() function), which misses the braces for the if statement, causing the function also to return if a non-payload program should be run causing the rest of the stages never to be run.
Change-Id: I04940b218ba71e82af769c8db574528f830d0cbb Found-by: Coverity, CID 1293136: Control flow issues (NESTING_INDENT_MISMATCH) Signed-off-by: Paul Menzel paulepanter@users.sourceforge.net --- src/arch/arm64/boot.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/arch/arm64/boot.c b/src/arch/arm64/boot.c index 312ffdd..f62ceb6 100644 --- a/src/arch/arm64/boot.c +++ b/src/arch/arm64/boot.c @@ -68,9 +68,10 @@ void arch_prog_run(struct prog *prog) void (*doit)(void *); void *arg;
- if (ENV_RAMSTAGE && prog->type == PROG_PAYLOAD) + if (ENV_RAMSTAGE && prog->type == PROG_PAYLOAD) { run_payload(prog); return; + }
doit = prog_entry(prog); arg = prog_entry_arg(prog);