Attention is currently required from: Martin Roth, zanxi chen.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51018 )
Change subject: mb/google/dedede/var/storo: Add USB Port Configuration
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/dedede/variants/storo/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/51018/comment/f8350338_ef7534f1
PS3, Line 5: smm-y += variant.c
Please fix that in a separate commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51018
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c070206ba0ec789710e5200a37d3f6d662ef9de
Gerrit-Change-Number: 51018
Gerrit-PatchSet: 3
Gerrit-Owner: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Sat, 27 Feb 2021 08:24:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment