Attention is currently required from: Andrey Petrov, Bora Guvendik, Ronak Kanabar, Subrata Banik, Wonkyu Kim.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80275?usp=email )
Change subject: drivers/intel/fsp2_0: Add FSP 2.4 support
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
some more generic feedback,
FSPM_ARCH2_UPD should need a EDK2 uprev. Please submit that as well as base CL.
Until things are not in place, I suggest to mark this CL as WIP
`FSPM_ARCH2_UPD` and `FSPS_ARCH2_UPD` are already available in src/vendorcode/intel/edk2/edk2-stable202302/IntelFsp2Pkg/Include/FspEas/FspApi.h.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80275?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1c24d26e105c3dcbd9cca0e7197ab1362344aa97
Gerrit-Change-Number: 80275
Gerrit-PatchSet: 3
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Wed, 31 Jan 2024 19:50:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment