Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32293 )
Change subject: smbios: Add memory type 9 system slot support
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/32293/1/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/32293/1/src/arch/x86/smbios.c@831
PS1, Line 831: const char *name, u8 type, u8 slot_char1,
make attributes const and use enums defined in smbios. […]
Done
https://review.coreboot.org/#/c/32293/1/src/arch/x86/smbios.c@849
PS1, Line 849: t->device_function_number = dev_func;
missing: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32293
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibcfa377c260083203c1daf5562e103001f76b257
Gerrit-Change-Number: 32293
Gerrit-PatchSet: 1
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Fri, 12 Apr 2019 20:23:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment