Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33824 )
Change subject: mainboard/google/hatch: create akemi variant.
......................................................................
Patch Set 17:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33824/17/src/mainboard/google/hatch...
File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
PS17:
I'd rather for the initial commit if you just put in a mostly empty devicetree; otherwise stuff may get left in for a while before it's noticed. All you should need for bringup would be the common_soc_config.gspi[0].early_init and .speed_mhz.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33824
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a868839e2c598f8052d37c99713bc58b21e887c
Gerrit-Change-Number: 33824
Gerrit-PatchSet: 17
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 07 Aug 2019 19:00:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment