[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8192: Add auxadc driver

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46390 )

Change subject: soc/mediatek/mt8192: Add auxadc driver
......................................................................

Patch Set 12:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46390/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/46390/4//COMMIT_MSG@10 
PS4, Line 10:
> AUXADC:  auxiliary analogue-to-digital conversion […]

Please merge your answer into the commit description.

https://review.coreboot.org/c/coreboot/+/46390/4/src/soc/mediatek/mt8192/aux... 
File src/soc/mediatek/mt8192/auxadc.c:

https://review.coreboot.org/c/coreboot/+/46390/4/src/soc/mediatek/mt8192/aux... 
PS4, Line 41: setbits32(&mt8192_infracfg->module_sw_cg_1_clr, 1 << 10);
            : 	assert(wait_ms(300, !(read32(&mtk_auxadc->con2) & 0x1)));
            : 
            : 	clrbits32(&mtk_auxadc->con1, 1 << channel);
            : 	assert(wait_ms(300, !(read32(&mtk_auxadc->data[channel]) & (1 << 12))));
            : 
            : 	setbits32(&mtk_auxadc->con1, 1 << channel);
            : 	udelay(25);
            : 	assert(wait_ms(300, read32(&mtk_auxadc->data[channel]) & (1 << 12)));
> First of all, wait_ms() will only delay 300ms in the worst case. […]

Is the 300ms documented somewhere in data sheet? If yes you can simply add a comment for it.