Attention is currently required from: Duncan Laurie, Angel Pons, Kyösti Mälkki.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48787 )
Change subject: [WIP] soc/intel/broadwell: Skip PRE_GRAPHICS_DELAY
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File src/soc/intel/broadwell/gma.c:
https://review.coreboot.org/c/coreboot/+/48787/comment/4b9be92f_dd7a79f7
PS2, Line 516: if (!acpi_is_wakeup_s3()) {
: if (!CONFIG(CHROMEOS) || display_init_required())
I did this for patchset #4 together with dropping CHROMEOS test, there is already VBOOT test in disp […]
I'm perfectly ok with dropping the entire hunk here. librem_bdw doesn't need it, and neither do any BDW CrOS boards built from upstream, even when using a VBIOS.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48787
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4503158576f35057373f003586bbf76af4d59b3d
Gerrit-Change-Number: 48787
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Duncan Laurie
dlaurie@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 04 Feb 2021 06:15:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment