[coreboot-gerrit] Change in coreboot[master]: mb/google/cyan: Clean up Kconfig

[Matt DeVillier (Code Review)]

Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39872 )

Change subject: mb/google/cyan: Clean up Kconfig
......................................................................

mb/google/cyan: Clean up Kconfig

Cyan has no VGA BIOS available (at least not publicly), so
remove related options. Disable SoC serial output by default,
since no production devices have this exposed, but leave it
as a user option so it can be selected as needed (eg,
for use with a Google debug servo).

Change-Id: Ic079a39ca5ad0ac653b52248244b94d4bfbd08a4
Signed-off-by: Matt DeVillier 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39872
Reviewed-by: Nico Huber 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/cyan/Kconfig
1 file changed, 6 insertions(+), 18 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved

diff --git a/src/mainboard/google/cyan/Kconfig b/src/mainboard/google/cyan/Kconfig
index 94ffbc0..4561054 100644
--- a/src/mainboard/google/cyan/Kconfig
+++ b/src/mainboard/google/cyan/Kconfig
@@ -6,7 +6,6 @@
    select EC_GOOGLE_CHROMEEC_LPC
    select EC_GOOGLE_CHROMEEC_MEC
    select EC_GOOGLE_CHROMEEC_ACPI_MEMMAP
-	select ENABLE_BUILTIN_COM1
    select HAVE_ACPI_TABLES
    select HAVE_OPTION_TABLE
    select INTEL_GMA_HAVE_VBT
@@ -73,23 +72,6 @@
    string
    default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"

-config VGA_BIOS_FILE
-	string
-	depends on VGA_BIOS
-	default "3rdparty/blobs/mainboard/intel/strago/vgabios.bin"
-	help
-	  The C0 version of the video BIOS gets computed from this name
-	  so that they can both be added.  Only the correct one for the
-	  system will be run.
-
-config VGA_BIOS_ID
-	string
-	depends on VGA_BIOS
-	default "8086,22b0"
-	help
-	  The VGA_BIOS_ID for the C0 version of the video BIOS is hardcoded
-	  in soc/intel/braswell/Makefile.inc as 8086,22b1
-
 config CBFS_SIZE
    hex
    default 0x200000
@@ -98,4 +80,10 @@
    string
    default "GOOGLE"

+config CONSOLE_SERIAL
+	default n
+
+config ENABLE_BUILTIN_COM1
+	default y if CONSOLE_SERIAL
+
 endif # BOARD_GOOGLE_BASEBOARD_CYAN