Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37551 )
Change subject: amd/hudson: Add PCI ID for FCH SATA Controller (AHCI Mode) for AMD driver ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37551/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37551/4//COMMIT_MSG@7 PS4, Line 7: Add PCI ID for FCH SATA Controller (AHCI Mode) for AMD driver Nit: at this point, you're no longer adding, but renaming.
https://review.coreboot.org/c/coreboot/+/37551/4//COMMIT_MSG@10 PS4, Line 10: This new device ID is found in the AMD Bettong board. : Support is added to configure properly the SATA device in initialization. This text looks a little stale too.
https://review.coreboot.org/c/coreboot/+/37551/1/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/37551/1/src/include/device/pci_ids.... PS1, Line 451: #define PCI_DEVICE_ID_AMD_CZ_SATA_AHCI_MS 0x7901
So Microsoft? I’d prefer AHCI in the code here, and add a comment, that it’s MS in the documentation […]
Paul, I infer Microsoft. I think I prefer simply ..._SATA_AHCI too, and leaving AHCI_AMD below as-is.