Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36418 )
Change subject: [NOT FOR MERGE]: Demo adding near_reset_vector symbol
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36418/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36418/1//COMMIT_MSG@35
PS1, Line 35: fffffe00 <_start16bit>:
You want objdump -M 8086 here
Oh, that's right. I was more concerned with showing where _start16bit was, and /searched down to "Disassembly of section .near_reset_vector:" (omitted). If there's any reason to repush the patch, I'll redo the text.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36418
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e7888c778e1d1cc426e4160543f4a4662ebf834
Gerrit-Change-Number: 36418
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 29 Oct 2019 00:22:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment