Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27605 )
Change subject: mainboard/google/nocturne: simplify camera power references
......................................................................
Patch Set 1:
Patch Set 1:
+Rajmohan, +Tomasz to comment on the reference count and how the kernel driver is handling it.
Looking at the linux kernel side of implementation: https://github.com/torvalds/linux/blob/master/drivers/acpi/power.c#L280, I agree with Matt, that this is already handled by acpi_power_off_unlocked to ensure that the power resource doesn't get turned off before its refcount drops to 0. So, the check in coreboot ACPI table seems redundant.
--
To view, visit
https://review.coreboot.org/27605
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c9f6c712b075450539d5b84ac5bb221b3cbb57e
Gerrit-Change-Number: 27605
Gerrit-PatchSet: 1
Gerrit-Owner: Matt Delco
delco@chromium.org
Gerrit-Assignee: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Rajmohan Mani
rajmohan.mani@intel.com
Gerrit-Reviewer: Tomasz Figa
tfiga@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Mon, 23 Jul 2018 18:00:30 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No