Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45571 )
Change subject: soc/intel/alderlake: Add GPIOs for Alder Lake SOC ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45571/1/src/soc/intel/alderlake/acp... File src/soc/intel/alderlake/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/45571/1/src/soc/intel/alderlake/acp... PS1, Line 11: CROS_GPIO_NAME
Have you verified that this matches the Linux kernel expectations? I know JSL and TGL used very diff […]
This name is as per GPIO chapter and linux should use the same name.
in TGL i could see https://github.com/coreboot/coreboot/blob/master/src/soc/intel/tigerlake/inc... and gpio.asl has hardcoded the same https://github.com/coreboot/coreboot/blob/master/src/soc/intel/tigerlake/acp...
https://review.coreboot.org/c/coreboot/+/45571/1/src/soc/intel/alderlake/gpi... File src/soc/intel/alderlake/gpio.c:
https://review.coreboot.org/c/coreboot/+/45571/1/src/soc/intel/alderlake/gpi... PS1, Line 27: The GPIO pinctrl driver for Alder Lake on Linux expects 32 GPIOs per pad
Have you confirmed this?
we have the same practice in CNL and TGL, and don't expect to change in ADL too (what i learn from chrome os team)
https://github.com/coreboot/coreboot/blob/master/src/soc/intel/cannonlake/gp...
https://review.coreboot.org/c/coreboot/+/45571/1/src/soc/intel/alderlake/gpi... PS1, Line 36: This layout matches the Linux kernel pinctrl map for ADL at: : * linux/drivers/pinctrl/intel/pinctrl-alderlake.c
What version of Linux kernel? I did not find this file in v5.9-rc6.
this is more over a placeholder as i understood,