Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41523 )
Change subject: device/pci_device: Do not complain about unassigned resources for PCI bridge ......................................................................
device/pci_device: Do not complain about unassigned resources for PCI bridge
This change prints an error for unassigned resource in pci_set_resource() only if the resource is a non-bridge resource. This is because bridge resource can remain unassigned if there are no downstream child devices requesting any resource of that type.
Change-Id: I8116cc8bdcf5a10049330600b1cb060d7880205a Signed-off-by: Furquan Shaikh furquan@google.com --- M src/device/pci_device.c 1 file changed, 10 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/41523/1
diff --git a/src/device/pci_device.c b/src/device/pci_device.c index 689325d..47b4613 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -450,9 +450,16 @@
/* Make certain the resource has actually been assigned a value. */ if (!(resource->flags & IORESOURCE_ASSIGNED)) { - printk(BIOS_ERR, "ERROR: %s %02lx %s size: 0x%010llx not " - "assigned\n", dev_path(dev), resource->index, - resource_type(resource), resource->size); + + /* + * Complain about unassigned resource only if this is not a bridge + * resource. Bridge resource can be left unassigned if the downstream child + * devices do not really need resource of a particular type. + */ + if (!(resource->flags & IORESOURCE_BRIDGE)) + printk(BIOS_ERR, "ERROR: %s %02lx %s size: 0x%010llx not " + "assigned\n", dev_path(dev), resource->index, + resource_type(resource), resource->size); return; }