Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38740 )
Change subject: mainboard/google/{hatch,fizz}: Fix gpio common code TODO
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38740/1/src/include/gpio.h
File src/include/gpio.h:
https://review.coreboot.org/c/coreboot/+/38740/1/src/include/gpio.h@22
PS1, Line 22: wait_for_gpio
Can you add function description? Especially return value and 200 ms poll period are important.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38740
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c67f04ae458a0e47f4bb022d744dd8b8a0789ee
Gerrit-Change-Number: 38740
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Daisuke Nojiri
dnojiri@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 08 Feb 2020 01:25:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment