build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44851 )
Change subject: soc/mediatek/mt8192: Add SPI flash controller DMA read function ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/44851/2/src/soc/mediatek/mt8192/fla... File src/soc/mediatek/mt8192/flash_controller.c:
https://review.coreboot.org/c/coreboot/+/44851/2/src/soc/mediatek/mt8192/fla... PS2, Line 150: } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44851/2/src/soc/mediatek/mt8192/fla... PS2, Line 150: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/44851/2/src/soc/mediatek/mt8192/fla... PS2, Line 151: return 0; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44851/2/src/soc/mediatek/mt8192/fla... PS2, Line 151: return 0; please, no spaces at the start of a line