Attention is currently required from: Nico Huber, Maciej Pijanowski, Martin L Roth, Michał Kotyla.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70102 )
Change subject: util/ectool/Makefile: improve cross-compilation support
......................................................................
Patch Set 2:
(1 comment)
File util/ectool/Makefile:
https://review.coreboot.org/c/coreboot/+/70102/comment/69c481b1_f15ca8a0
PS1, Line 3: CC ?= gcc
It is typical for cross-compilation environments to expose these via environment variables. See e.g. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70102
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If5c88bde0ae00f0211a250906cbdedfe4f59c67b
Gerrit-Change-Number: 70102
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Kotyla
michal.kotyla@3mdeb.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: maciej.gabryelski@3mdeb.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Michał Kotyla
michal.kotyla@3mdeb.com
Gerrit-Comment-Date: Wed, 30 Nov 2022 12:24:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Comment-In-Reply-To: Michał Kotyla
michal.kotyla@3mdeb.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment