Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44675 )
Change subject: cpu/x86/mp_init: Add support for x86_64
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44675/1/src/cpu/x86/mp_init.c
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/44675/1/src/cpu/x86/mp_init.c@351
PS1, Line 351: uintptr_t
Has the potential to overflow the uint32_t c_handler? […]
LGTM and fix/improve this later on.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44675
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7190d24172803e40acaf1495ce20f3ea38016b0
Gerrit-Change-Number: 44675
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 21 Oct 2020 10:46:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment