Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45286 )
Change subject: amdfwtool: Clean up the Makefile of amdfwtool ......................................................................
Patch Set 14:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45286/11/util/amdfwtool/Makefile File util/amdfwtool/Makefile:
https://review.coreboot.org/c/coreboot/+/45286/11/util/amdfwtool/Makefile@17 PS11, Line 17: amdfwtool_exe
change to 'all:' or remove?
Done
https://review.coreboot.org/c/coreboot/+/45286/11/util/amdfwtool/Makefile@17 PS11, Line 17: amdfwtool_exe : $(TARGET)
Is this doing anything or can it be removed?
Done
https://review.coreboot.org/c/coreboot/+/45286/1/util/amdfwtool/Makefile.inc File util/amdfwtool/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45286/1/util/amdfwtool/Makefile.inc... PS1, Line 11: -Wno-sign-compare
Why? I think we'd want to know this.
Done. Fix the compiling warning in another patch
https://review.coreboot.org/c/coreboot/+/45286/11/util/amdfwtool/Makefile.in... File util/amdfwtool/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45286/11/util/amdfwtool/Makefile.in... PS11, Line 8: printf " AMDFWTOOL\n"
this gets added here and removed in a follow-up patch, so you could remove that here to have all cha […]
Done