Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45059 )
Change subject: soc/amd/picasso: pass verstage timestamps to x86 ......................................................................
Patch Set 8:
(5 comments)
https://review.coreboot.org/c/coreboot/+/45059/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45059/6//COMMIT_MSG@16 PS6, Line 16: Adding value directly to TSC can sovle it, it will be kept across
nit "solve"
Done
https://review.coreboot.org/c/coreboot/+/45059/6/src/soc/amd/picasso/bootblo... File src/soc/amd/picasso/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/45059/6/src/soc/amd/picasso/bootblo... PS6, Line 124: struct transfer_info_struct *info = (struct transfer_info_struct *)
this assumes I have a transfer buffer set up. […]
_transfer_buffer is defined in src/soc/amd/picasso/memlayout_x86.ld and guarded with CONFIG(VBOOT). Do we also need to worry about when VBOOT is not used?
https://review.coreboot.org/c/coreboot/+/45059/6/src/soc/amd/picasso/bootblo... PS6, Line 144: wrmsr(TSC_MSR, msr);
Yes kernel complained about it - […]
Latest patchset does not touch TSC value
https://review.coreboot.org/c/coreboot/+/45059/6/src/soc/amd/picasso/bootblo... PS6, Line 161: tse->entry_stamp = psp_ts_table->base_time + tse->entry_stamp;
nit: +=
https://review.coreboot.org/c/coreboot/+/45059/6/src/soc/amd/picasso/bootblo... PS6, Line 161: psp_ts_table->base_tim
Assuming 1us unit.
Stated in the comments.