Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32743 )
Change subject: mb/t400/acpi: Update ATPR buffer to fit all entries ......................................................................
Patch Set 5: Code-Review-1
(1 comment)
This is part of a kernel interface (cf. `drivers/gpu/drm/ amd/amdgpu/amdgpu_atpx_handler.c`), please find a solution that doesn't break the ABI.
https://review.coreboot.org/#/c/32743/5/src/mainboard/lenovo/t400/acpi/graph... File src/mainboard/lenovo/t400/acpi/graphics.asl:
https://review.coreboot.org/#/c/32743/5/src/mainboard/lenovo/t400/acpi/graph... PS5, Line 68: These offsets look all correct.
Would be worth to add a comment that they specify different, incompatible structures, `struct atpx_verify_interface` and `struct atpx_px_params` in the kernel. However, as the latter is not implemented here anyway, we can also just drop `MASK` and `FLAG`.