Attention is currently required from: Raul Rangel, Martin Roth, Mathew King, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51473 )
Change subject: mb/google/guybrush: Add initial fch irq routing
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/guybrush/mainboard.c:
https://review.coreboot.org/c/coreboot/+/51473/comment/fde60c41_f417ca2a
PS3, Line 20:
I would ideally like to see this table defined in device tree. […]
I won't -2 this one. But I'd like to see Felix ack this with his +2, as it appears he has taken some ownership of soc/amd/common management and deduplication work. And this will be one more copy to his assignments.
Should older AGESA and binaryPI survive through next release (May 2021), someone probably takes interest in such finalized IRQ API. CB:38564.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51473
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1abb070324254e21b03bfe00d6eee3b70120564c
Gerrit-Change-Number: 51473
Gerrit-PatchSet: 3
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 15 Mar 2021 06:50:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment