Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32262 )
Change subject: vboot: refactor OPROM code
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32262/4/src/security/vboot/misc.h
File src/security/vboot/misc.h:
https://review.coreboot.org/#/c/32262/4/src/security/vboot/misc.h@40
PS4, Line 40: uint32_t buffer_size;
Yes. Also, I'm a moron. buffer_offset may need to be larger than 64K. Don't listen to me. […]
Shit, did I submit this already? I shouldn't try to get stuff done while having to jump off the bus.
buffer_offset is of course always 16 right now and will very easily fit in a u16.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32262
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf111a533c3953448b4b9084885a9a65a2432a8b
Gerrit-Change-Number: 32262
Gerrit-PatchSet: 5
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Randall Spangler
rspangler@google.com
Gerrit-Reviewer: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 16 Apr 2019 04:05:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Gerrit-MessageType: comment