Attention is currently required from: Alexander Couzens, Patrick Rudolph.
Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/85944?usp=email )
Change subject: mb/lenovo/x131e: Remove old USB configurations ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/lenovo/x131e/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/85944/comment/3f504e4b_8d5c1259?usp... : PS2, Line 45: 0x00000c03
according to schematics P0 and P1 are the only USB3.0 ports and both connected to OC0#. […]
And it matches usb_port_config, unconnected P2 also being assigned to OC0#. So to reconcile, there are two ways:
1. Leave the patch as is and let XOCM be programmed as 0x00000007. 2. Change P2 to have no OC and let XOCM be programmed as 0x00000003.
OC1# appears completely unused according to this usb_port_config. If that is also what your schematics say, this will be fine.
What would you like done?