Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32020 ) Change subject: [WIP]x86: Introduce the blobolator ...................................................................... Patch Set 2: coreboot's version of x86emu has been significantly refactored for code size. It would be interesting to upstream these changes, albeit that's a lot of work as the original diffs have not been preserved (LinuxBIOS v1 timeframe, and only the final refactored product was posted back then) - Please do not add a second copy of x86emu to the tree. - If we decide that this copy should replace the size optimized version, please make sure you test with yabel and the native bios emulation on a fair number of option roms to not break the existing code. Stefan -- To view, visit https://review.coreboot.org/c/coreboot/+/32020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13e47f45e69376d046f35c04363fe3db1cfaa610 Gerrit-Change-Number: 32020 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Daniel Maslowski <info@orangecms.org> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-CC: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-CC: Thomas Heijligen <src@posteo.de> Gerrit-Comment-Date: Mon, 25 Mar 2019 08:44:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment