Attention is currently required from: Alper Nebi Yasak, Philipp Hug, ron minnich.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80378?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mainboard/qemu-riscv: Add PCI support ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/emulation/qemu-riscv/include/mainboard/addressmap.h:
https://review.coreboot.org/c/coreboot/+/80378/comment/c616edca_d5f94975 : PS1, Line 12: #define QEMU_VIRT_PCIE_ECAM_BASE 0x30000000 : #define QEMU_VIRT_PCIE_ECAM_SIZE 0x3fffffff probably not needed, since there are CONFIG_ECAM_MMCONF_BASE_ADDRESS and CONFIG_ECAM_MMCONF_LENGTH. also the last one isn't a size, but a last address, right?
File src/mainboard/emulation/qemu-riscv/mainboard.c:
https://review.coreboot.org/c/coreboot/+/80378/comment/2e09d69b_51fa6f61 : PS1, Line 47: mmio_range(dev, index++, QEMU_VIRT_PCIE_ECAM_BASE, QEMU_VIRT_PCIE_ECAM_SIZE); can mmconf_resource be used instead?