Attention is currently required from: Alper Nebi Yasak, Philipp Hug, ron minnich.
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
2 comments:
File src/mainboard/emulation/qemu-riscv/include/mainboard/addressmap.h:
#define QEMU_VIRT_PCIE_ECAM_BASE 0x30000000
#define QEMU_VIRT_PCIE_ECAM_SIZE 0x3fffffff
probably not needed, since there are CONFIG_ECAM_MMCONF_BASE_ADDRESS and CONFIG_ECAM_MMCONF_LENGTH. also the last one isn't a size, but a last address, right?
File src/mainboard/emulation/qemu-riscv/mainboard.c:
Patch Set #1, Line 47: mmio_range(dev, index++, QEMU_VIRT_PCIE_ECAM_BASE, QEMU_VIRT_PCIE_ECAM_SIZE);
can mmconf_resource be used instead?
To view, visit change 80378. To unsubscribe, or for help writing mail filters, visit settings.