Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37667 )
Change subject: libpayload: Read from cbmem console ......................................................................
Patch Set 2:
(2 comments)
Patch Set 2:
(6 comments)
I'm not very convinced if this must be inside libpayload, since it'll need to copy whole buffer; maybe the payload can be more efficient on reading only the contents of one page, and scroll/update on demand.
In this case, we'll have to remember the offset that has been read. However, it's possible that the data from the offset is overwritten before the next scroll/update call.
https://review.coreboot.org/c/coreboot/+/37667/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37667/2//COMMIT_MSG@12 PS2, Line 12: returned string is printable.
I was wondering, why there might be unprintable characters, and found your comment in the implementa […]
Ack
https://review.coreboot.org/c/coreboot/+/37667/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/cbmem_console.c:
https://review.coreboot.org/c/coreboot/+/37667/2/payloads/libpayload/drivers... PS2, Line 79: size_t
uint32_t ?
I just want to be consistent with cbmem_console_write().