Attention is currently required from: Julius Werner, Lean Sheng Tan, Paul Menzel, Subrata Banik, Werner Zeh.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74765?usp=email )
Change subject: soc/intel/cmn/block/cse: Support sending EOP from payload
......................................................................
Patch Set 12:
(1 comment)
Patchset:
PS12:
I guess this is explainable due to the nature of how this feature works? […]
Currently I am not seeing the regression.
I investigated the below segment as well but I am not seeing any difference with/without this CL -
```
# cbmem -t
...
60:device initialization 959,184 (577)
15:starting LZMA decompress (ignore for x86) 964,119 (4,934)
16:finished LZMA decompress (ignore for x86) 964,220 (101)
114:started elog init 979,189 (14,968)
115:finished elog init 982,740 (3,550)
...
```
```
# cbmem -c1 | grep -in "BS: BS_DEV_INIT "
2377:[DEBUG] BS: BS_DEV_INIT run times (exec / console): 20 / 0 ms
2383:[DEBUG] BS: BS_DEV_INIT exit times (exec / console): 4 / 0 ms
```
```
# cbmem -c1 | grep -in "init finished in" | grep -v "0 msecs"
2036:[DEBUG] Root Device init finished in 4 msecs
2224:[DEBUG] PCI: 00:1f.2 init finished in 12 msecs
```
I will try it on a few more boards.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74765?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0fbb9fd0f8522eefad39960ca3167c2ba764f523
Gerrit-Change-Number: 74765
Gerrit-PatchSet: 12
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: sridhar siricilla
siricillasridhar@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Fri, 03 Nov 2023 16:12:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment