[coreboot-gerrit] Change in ...coreboot[master]: AGESA fam15tn boards: Clean up devicetree

[mikeb mikeb (Code Review)]

mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30734 )

Change subject: AGESA fam15tn boards: Clean up devicetree
......................................................................

Patch Set 3: Code-Review+1

Finally I tested this change on my Lenovo G505S laptop and it still boots :) Compared to this board status report from the end of December - https://review.coreboot.org/cgit/board-status.git/tree/lenovo/g505s/4.9-8-g4... - there are no real changes at Linux kernel dmesg log, but now lspci -vvxxx shows a different PCI config space for 00:18.2 device, hopefully as expected and these differences below are okay (meld/kdiff3 to highlight)

Please let me know if any further tests are needed ( are there any software tests for 00:18.2 device which I could run to verify its' functionality? )

P.S. Also, I've been CC'd regarding CB:21624 change but it's marked as [WIP]. Is it ready for testing on real hardware?

===> BEFORE :

00:18.2 Host bridge: Advanced Micro Devices, Inc. [AMD] Family 15h (Models 10h-1fh) Processor Function 2
    Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
    Status: Cap- 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
00: 22 10 02 14 00 00 00 00 00 00 00 06 00 00 80 00
10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
20: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
30: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
40: 01 00 00 00 21 00 00 00 00 00 00 00 00 00 00 00
50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
60: c0 ff f8 01 00 00 00 00 00 00 00 00 00 00 00 00
70: 00 00 00 00 00 00 00 00 00 00 02 00 98 00 28 18
80: 0a 00 00 00 05 00 80 00 00 00 00 3c 00 00 02 00
90: 00 00 01 03 92 88 59 9f 2f 81 0f 8d a1 00 00 00
a0: 20 02 1d 03 00 00 00 00 00 00 32 80 00 00 00 00
b0: 68 2c 7a 7b 3e 00 00 00 4f df f9 e2 6e ad 02 6c
c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
d0: e0 79 ff ff af a6 ab ff ff eb ff bb f7 ce 95 ef
e0: e0 c2 86 ee b7 ea ef 77 e7 43 f7 7b f5 f0 61 ab
f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
===> AFTER:
00:18.2 ---//---
00: 22 10 02 14 00 00 00 00 00 00 00 06 00 00 80 00
10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
20: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
30: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
40: 01 00 00 00 21 00 00 00 00 00 00 00 00 00 00 00
50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
60: c0 ff f8 01 00 00 00 00 00 00 00 00 00 00 00 00
70: 00 00 00 00 00 00 00 00 00 00 02 00 98 00 28 18
80: 0a 00 00 00 05 00 80 00 00 00 00 3c 00 00 02 00
90: 00 00 01 03 92 88 59 9f 2f 81 0f 8d a1 00 00 00
a0: a0 02 1d 03 00 00 00 00 00 00 32 80 00 00 00 00
b0: 5e b3 29 db ef 00 00 00 4f df f9 a2 6e 84 02 6c
c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
d0: e0 79 fd ff 2f a6 ab bf ec 98 71 ce f7 86 97 ef
e0: f0 c2 84 ee be ea ed 7f e7 43 f7 7b b5 f0 61 ab
f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00