Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36654 )
Change subject: libpayload: keyboard: Ignore special keys ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36654/5/payloads/libpayload/drivers... File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/36654/5/payloads/libpayload/drivers... PS5, Line 247: CONFIG_LP_PC_KEYBOARD_TREAT_MEDIA_KEYS_AS_FN I don't think we need a new config for this, just check that media_key_mapping is not null.
https://review.coreboot.org/c/coreboot/+/36654/5/payloads/libpayload/include... File payloads/libpayload/include/libpayload.h:
https://review.coreboot.org/c/coreboot/+/36654/5/payloads/libpayload/include... PS5, Line 185: int I know I had this as an int but I now think it should be an unsigned short