Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35993 )
Change subject: cpu/x86: Add a prog_run hook to set up caching of XIP stages
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35993/14/src/cpu/x86/mtrr/xip_cache...
File src/cpu/x86/mtrr/xip_cache.c:
https://review.coreboot.org/c/coreboot/+/35993/14/src/cpu/x86/mtrr/xip_cache...
PS14, Line 85: >
Shouldn't this be >=?
... I see Aaron posted this question on a previous patchset, but I don't see a response to that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35993
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I94d5771a57ffd74d53db3e35fe169d77d7fbb8cd
Gerrit-Change-Number: 35993
Gerrit-PatchSet: 14
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 29 Oct 2019 18:03:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment