13 Oct
2020
13 Oct
'20
12:44 a.m.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45535 )
Change subject: soc/intel/common/block/acpi: add code for CPPC entries generation ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45535/4/src/soc/intel/common/block/... File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/45535/4/src/soc/intel/common/block/... PS4, Line 370: core == 0
!core?
well, we're checking the core id here which is int, not bool. while it wouldn't make a difference practically, it's simply wrong IMO
--
To view, visit https://review.coreboot.org/c/coreboot/+/45535
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1fcc2d0d7c6b6f35f8dd011f55dab8469be99d47
Gerrit-Change-Number: 45535
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Elyes HAOUAS
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-Comment-Date: Mon, 12 Oct 2020 22:44:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com
Gerrit-MessageType: comment