[coreboot-gerrit] Change in coreboot[master]: src/console/Kconfig: Add option to disable loglevel prefix

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63144 )

Change subject: src/console/Kconfig: Add option to disable loglevel prefix
......................................................................

src/console/Kconfig: Add option to disable loglevel prefix

This patch adds an option to disable loglevel prefixes. This patch helps
to achieve clear messages when low loglevel is used and very few
messages are displayed on a terminal. This option also allows to
maintain compatibility with log readers and continuous integration
systems that depend on fixed log content.

If the code contains:
  printk(BIOS_DEBUG, "This is a debug message!\n")
it will show as:
  [DEBUG]  This is a debug message!
but if the Kconfig contains:
  CONFIG_CONSOLE_USE_LOGLEVEL_PREFIX=n
the same message will show up as
  This is a debug message!

Signed-off-by: Igor Bagnucki 
Change-Id: I911bb601cf1933a4c6498b2ae1e4cb4d4bc85621
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63144
Tested-by: build bot (Jenkins) 
Reviewed-by: Julius Werner 
---
M src/console/Kconfig
M src/console/printk.c
2 files changed, 11 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Julius Werner: Looks good to me, approved

diff --git a/src/console/Kconfig b/src/console/Kconfig
index 37d8fef..6152592 100644
--- a/src/console/Kconfig
+++ b/src/console/Kconfig
@@ -395,6 +395,15 @@

endif

+config CONSOLE_USE_LOGLEVEL_PREFIX
+	bool "Use loglevel prefix to indicate line loglevel"
+	default y
+	help
+	  When enabled, if the code contains a:
+	  `printk(BIOS_DEBUG, "This is a debug message!\n")`,
+	  it will show up as:
+	  `[DEBUG]  This is a debug message!`
+
 config CONSOLE_USE_ANSI_ESCAPES
    bool "Use ANSI escape sequences for console highlighting"
    default y
diff --git a/src/console/printk.c b/src/console/printk.c
index eb35c53..1ce2fad 100644
--- a/src/console/printk.c
+++ b/src/console/printk.c
@@ -96,7 +96,8 @@
       and potentially an escape sequence for highlighting. */
    if (CONFIG(CONSOLE_USE_ANSI_ESCAPES))
    	wrap_interactive_printf(BIOS_LOG_ESCAPE_PATTERN, bios_log_escape[state.level]);
-	wrap_interactive_printf(BIOS_LOG_PREFIX_PATTERN, bios_log_prefix[state.level]);
+	if (CONFIG(CONSOLE_USE_LOGLEVEL_PREFIX))
+		wrap_interactive_printf(BIOS_LOG_PREFIX_PATTERN, bios_log_prefix[state.level]);
 }

static void line_end(union log_state state)