Nico Huber has posted comments on this change. ( https://review.coreboot.org/29378 )
Change subject: nb/intel/haswell: Add a PCI ID for a desktop memory controller ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/29378/1/src/northbridge/intel/haswell/haswel... File src/northbridge/intel/haswell/haswell.h:
https://review.coreboot.org/#/c/29378/1/src/northbridge/intel/haswell/haswel... PS1, Line 213: #define PCI_DEVICE_ID_HSW_DESKTOP 0x0c00 actually, we have a common header file for such definitions
https://review.coreboot.org/#/c/29378/1/src/northbridge/intel/haswell/northb... File src/northbridge/intel/haswell/northbridge.c:
https://review.coreboot.org/#/c/29378/1/src/northbridge/intel/haswell/northb... PS1, Line 468: }; I guess you could alternatively combine all three `pci_driver`s and use a `.devices` list.