Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45345 )
Change subject: soc/intel/common/block: Move PRMRR options to CPU subfolder
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45345/2/src/soc/intel/common/block/...
File src/soc/intel/common/block/cpu/Kconfig:
https://review.coreboot.org/c/coreboot/+/45345/2/src/soc/intel/common/block/...
PS2, Line 106: prompt "PRMRR size"
Oh, I overlooked that... […]
Oooof, that changes everything, ofc. But that means we should also clarify
a lot because we'd make the assumption that
The `PrmrrSize` UPD doesn't (fully) control the PRMRR size.
In that case, I vote for renaming get_prmrr_size() to make it clear that
it's not the effective size. Currently it's only called to set the UPD.
We should make sure nobody calls it and assumes that it will return the
effective size.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45345
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27f1d3741e8e3755130078c79ab13ae8873354fc
Gerrit-Change-Number: 45345
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 15 Sep 2020 09:03:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment