Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46327 )
Change subject: soc/amd/picasso: Override weak functions for ioapic_id ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46327/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46327/1//COMMIT_MSG@7 PS1, Line 7: .
nit: no trailing period here
I'll remove it.
https://review.coreboot.org/c/coreboot/+/46327/1//COMMIT_MSG@11 PS1, Line 11: CONFIG_PICASSO_GNB_IOAPIC_ID.
Why are other values needed?
This new design allows coreboot to dictate what the ioapic IDs will be and communicate to the FSP what it wants to use. It will put coreboot in the driverseat and allow more flexibility.
https://review.coreboot.org/c/coreboot/+/46327/1/src/soc/amd/common/block/sm... File src/soc/amd/common/block/smbus/sm.c:
https://review.coreboot.org/c/coreboot/+/46327/1/src/soc/amd/common/block/sm... PS1, Line 20: setup_ioapic(VIO_APIC_VADDR, soc_get_fch_ioapic_id());
Shouldn’t this go into the other commit?
i could have. when i submitted it made sense to make the change for all consumers of the helper function together.