mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31449 )
Change subject: src/device/Kconfig: Add support for discrete VGA OpROM inclusion at config UI ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/31449/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31449/1//COMMIT_MSG@9 PS1, Line 9:
Please remove the space.
Done.
https://review.coreboot.org/#/c/31449/1/src/device/Kconfig File src/device/Kconfig:
https://review.coreboot.org/#/c/31449/1/src/device/Kconfig@617 PS1, Line 617: bool "Add a Discrete VGA BIOS image"
discrete
Done.
https://review.coreboot.org/#/c/31449/1/src/device/Kconfig@618 PS1, Line 618: depends on ARCH_X86 && MULTIPLE_VGA_ADAPTERS
MULTIPLE_VGA_ADAPTERS seems to be some ancient Kconfig that should no longer be used.
I disagree: MULTIPLE_VGA_ADAPTERS option already surrounds important AMD-specific code at AMD northbridges, more information at https://review.coreboot.org/c/coreboot/+/31448#message-b19757941999d0b435fc0...
https://review.coreboot.org/#/c/31449/1/src/device/Kconfig@620 PS1, Line 620: Select this option if you have a VGA BIOS image for Discrete GPU
discrete
Done.