View Change
4 comments:
Commit Message:
File src/device/Kconfig:
Patch Set #1, Line 617: bool "Add a Discrete VGA BIOS image"
discrete
Done.
Patch Set #1, Line 618: depends on ARCH_X86 && MULTIPLE_VGA_ADAPTERS
MULTIPLE_VGA_ADAPTERS seems to be some ancient Kconfig that should no longer be used.
I disagree: MULTIPLE_VGA_ADAPTERS option already surrounds important AMD-specific code at AMD northbridges, more information at https://review.coreboot.org/c/coreboot/+/31448#message-b19757941999d0b435fc04619de50ea210485e81
Patch Set #1, Line 620: Select this option if you have a VGA BIOS image for Discrete GPU
discrete
Done.
To view, visit change 31449. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a7bf0fe95c833cf3df0c7cb20fc27b6ab218c5a
Gerrit-Change-Number: 31449
Gerrit-PatchSet: 2
Gerrit-Owner: mikeb mikeb <mikebdp2@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: mikeb mikeb <mikebdp2@gmail.com>
Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-CC: Patrick Rudolph <siro@das-labor.org>
Gerrit-Comment-Date: Mon, 18 Feb 2019 19:15:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <siro@das-labor.org>
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: comment