[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/uart: Use simple(_s_) variants of PCI functions

[Furquan Shaikh (Code Review)]

Attention is currently required from: Angel Pons.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49213 )

Change subject: soc/intel/common/uart: Use simple(_s_) variants of PCI functions
......................................................................

Patch Set 3:

(3 comments)

File src/soc/intel/common/block/uart/uart.c:

https://review.coreboot.org/c/coreboot/+/49213/comment/b851e479_5355678c 
PS2, Line 61: devfn
> `uart_console_get_pci_bdf` ?

Done

https://review.coreboot.org/c/coreboot/+/49213/comment/b9cf3bff_ed2ea0aa 
PS2, Line 84: pci_devfn_t devfn
> These should be renamed to `dev` to avoid confusion with actual devfn-only values elsewhere.

Done

https://review.coreboot.org/c/coreboot/+/49213/comment/ef7f8e41_53031f4f 
PS2, Line 215: if (uart_controller_needs_init(dev)) {
             : 		uintptr_t base;
             : 		pci_devfn_t devfn = PCI_BDF(dev);
             : 
             : 		base = pci_s_read_config32(devfn, PCI_BASE_ADDRESS_0) & ~0xFFF;
             : 		if (base)
             : 			uart_lpss_init(devfn, base);
             : 	}
> Ack.

Done