Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41900 )
Change subject: drivers/xhci/acpi: Add a driver to generate xHCI ACPI nodes ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41900/3/src/drivers/xhci/acpi/Makef... File src/drivers/xhci/acpi/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/41900/3/src/drivers/xhci/acpi/Makef... PS3, Line 1: xhci_acpi I don't think this is dealing just with ACPI. Also, should this be placed under drivers/usb? Something like drivers/usb/pci_xhci/xhci.c
https://review.coreboot.org/c/coreboot/+/41900/3/src/drivers/xhci/acpi/xhci_... File src/drivers/xhci/acpi/xhci_acpi.c:
https://review.coreboot.org/c/coreboot/+/41900/3/src/drivers/xhci/acpi/xhci_... PS3, Line 92: counts How does counts get used? I see that handle_xhci_ext_cap() is setting it. But, it doesn't really get used anywhere.