Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40724 )
Change subject: drivers/intel/gma: Move IGD OpRegion to CBMEM
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40724/6/src/soc/intel/apollolake/gr...
File src/soc/intel/apollolake/graphics.c:
https://review.coreboot.org/c/coreboot/+/40724/6/src/soc/intel/apollolake/gr...
PS6, Line 23: uint32_t reg32 = pci_read_config32(dev, PCI_COMMAND);
: reg32 |= PCI_COMMAND_MASTER;
: pci_write_config32(dev, PCI_COMMAND, reg32);
it's not problematic to enable bus mastering on the FSP/GOP path, SKL does it too and no issues. […]
Moved intel_gma_init_igd_opregion() up, so we can keep the FSP bail-out.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40724
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fdd6634e4a671a85b1df8bc9815296ff42edf29
Gerrit-Change-Number: 40724
Gerrit-PatchSet: 7
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 May 2020 17:43:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment