Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32614 )
Change subject: soc/skl/memmap: calculate mem size even if IGD undefined in devtree ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/32614/1/src/soc/intel/skylake/memmap.c File src/soc/intel/skylake/memmap.c:
https://review.coreboot.org/#/c/32614/1/src/soc/intel/skylake/memmap.c@175 PS1, Line 175: dev_find_slot
Please use pcidev_path_on_root(). […]
Thank you for the review. I will use pcidev_path_on_root() from now on.
https://review.coreboot.org/#/c/32614/1/src/soc/intel/skylake/memmap.c@205 PS1, Line 205: dev_find_slot
Please use pcidev_path_on_root().
Done
https://review.coreboot.org/#/c/32614/1/src/soc/intel/skylake/memmap.c@205 PS1, Line 205: root_dev
`root_dev` reads a little odd here, because it's not the root of the […]
Ok. I use neutral dev here