Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58652 )
Change subject: src/device/pci: add support for AMD_DGPU_WITHOUT_EEPROM init and OpROM loading ......................................................................
Patch Set 1:
(2 comments)
File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/58652/comment/4a8a2681_db602538 PS1, Line 754: PCI_CLASS_DISPLAY_OTHER Arthur Heymans: "Instead of modifying the pci_dev_init, create a [coreboot] PCI driver for the discrete GPU on your device with a different init function, i.e. to load the option ROM without executing it. It could even load the option rom at other available addresses, to not conflict with the VGA option ROM loading."
https://review.coreboot.org/c/coreboot/+/58652/comment/683b490b_37f3c1e8 PS1, Line 774: pci_rom_load Arthur Heymans: "This always loads the rom at 0xC0000 which is generally used for the device decoding VGA. Why not have a device specific driver to also load roms at the next option ROM address 0xD0000?"