Attention is currently required from: Arthur Heymans, Lance Zhao, Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Paul Menzel, Tim Wawrzynczak, Christian Walter, Angel Pons, Shuming Chu (Shuming), TangYiwei.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68912 )
Change subject: soc/intel/xeon_sp: Don't sort struct device cpus for numa
......................................................................
Patch Set 28:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68912/comment/a95b324d_f2b473fd
PS24, Line 13: it's
its
Done
https://review.coreboot.org/c/coreboot/+/68912/comment/9ab8aaf2_3d296d0f
PS24, Line 16: entry (now it is done in
: parallel too as a bonus).
Please add the dot/period after entry, and make the sentence in the brackets start with capital lett […]
Done
https://review.coreboot.org/c/coreboot/+/68912/comment/f7f2b4a0_373094d6
PS24, Line 18:
Tested on what board?
Previous patches were tested on ocp/deltalake. current patchset is untested.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68912
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I372bcea1932d28e9bf712cc712f19a76fe3199b1
Gerrit-Change-Number: 68912
Gerrit-PatchSet: 28
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-CC: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: TangYiwei
Gerrit-Comment-Date: Tue, 04 Apr 2023 12:31:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment